Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide p100() from transaction summary by default #20919

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Hide p100() from transaction summary by default #20919

merged 2 commits into from
Sep 23, 2020

Conversation

silent1mezzo
Copy link
Contributor

Can be disabled by passing in unselectedSeries: null to transactionSummaryRouteWithQuery e.g.

const target = transactionSummaryRouteWithQuery({
  orgSlug: organization.slug,
  transaction: String(dataRow.transaction) || '',
  query: summaryView.generateQueryStringObject(),
  projectID,
  unselectedSeries: null,
});

Previously when clicking through to the Transaction Summary:
Screen Shot 2020-09-22 at 2 05 21 PM

Now:
Screen Shot 2020-09-22 at 2 05 28 PM

@silent1mezzo silent1mezzo requested a review from a team as a code owner September 22, 2020 18:06
@github-actions
Copy link
Contributor

size-limit report

Path Size
public/app.js 235.09 KB (0%)
public/vendor.js 447.8 KB (0%)

Zylphrex
Zylphrex approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@Zylphrex Zylphrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

k-fish
k-fish reviewed Sep 22, 2020
View reviewed changes
src/sentry/static/sentry/app/views/performance/transactionSummary/utils.tsx Outdated
}: {
orgSlug: string;
transaction: string;
query: Query;
unselectedSeries?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string | string[]? you should be able to unselect multiple.

markstory
markstory approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The DurationChart component uses the same URL parameter to deselect series.

@silent1mezzo silent1mezzo merged commit 6b777aa into master Sep 23, 2020
@silent1mezzo silent1mezzo deleted the ui/p100 branch September 23, 2020 13:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markstory markstory markstory approved these changes

@k-fish k-fish k-fish approved these changes

@Zylphrex Zylphrex Zylphrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silent1mezzo @markstory @k-fish @Zylphrex