Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(ts): Set children on Forms as optional #20953

Merged
merged 1 commit into from Sep 25, 2020
Merged

ref(ts): Set children on Forms as optional #20953

merged 1 commit into from Sep 25, 2020

Conversation

leedongwei
Copy link
Member

@leedongwei leedongwei commented Sep 24, 2020 •
edited

Required to unblock getsentry PR mentioned below.

@leedongwei leedongwei requested a review from a team September 24, 2020 07:31
@github-actions
Copy link
Contributor

size-limit report

Path Size
public/app.js 235.35 KB (0%)
public/vendor.js 447.8 KB (0%)

markstory
markstory approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component uses children in a way that will be compatible with it being undefined.

@leedongwei leedongwei merged commit 8e4412e into master Sep 25, 2020
@leedongwei leedongwei deleted the dlee/ref-form-type branch September 25, 2020 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markstory markstory markstory approved these changes

@dashed dashed dashed approved these changes

@priscilawebdev priscilawebdev priscilawebdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leedongwei @markstory @dashed @priscilawebdev