feat(grouping): java enhancer-by-guice wont group

[bruno-garcia]

Added to the common ruleset as @mitsuhiko suggested #18959 (comment)

Note: Isn't family:other mean we'll apply this rule to all events of all platforms (other than what's covered by native and javascript)? If so should I add a new family java and map platform=java to it?

Resolves #21645

Resolves: getsentry/sentry-java#1018

TODO:
Add in to resole: #18959

'sun.reflect.GeneratedMethodAccessor' and 'sun.reflect.GeneratedConstructorAccessor'

Also add *$$FastClassByGuice$$*

[philipphofmann]

Thanks, @bruno-garcia for taking care of this. I understand how this can solve #21645, but I don't get it how this solves #18959, as this PR doesn't include a rule about GeneratedConstructorAccessorXX.

[philipphofmann]

m: I think it would be nice to add a comment on what EnhancerByGuice actually is and which problem this rule solves. If I'm not mistaken it is generated by Google Guice.

[bruno-garcia]

Literally pasting this string shows up what this is about though, not sure:

Generated code by Google Guice

is as useful as it is noise.

[bruno-garcia]

Thanks, @bruno-garcia for taking care of this. I understand how this can solve #21645, but I don't get it how this solves #18959, as this PR doesn't include a rule about GeneratedConstructorAccessorXX.

This is a fair point, I'll add a rule for this too once @mitsuhiko validates the general approach and test.

[philipphofmann]

I agree that you can find out in a minute were EnhancerByGuice comes from. Still, we have some information in the issues and also in this PR that is not obvious by this line of code. So you would have to do git blame to find the corresponding PR and read the issue to find out why this rule is here.

[marandaneto]

should we also ad *FastClassByGuice*?

https://github.com/google/guice/blob/fdfc81cde4f0dc1811489715a34b3632d9dfacd5/core/src/com/google/inject/internal/BytecodeGen.java#L69-L71

[bruno-garcia]

I wasn't aware of this, good one, I'll add.

[bruno-garcia]

Create Family with Java and Groovy

[github-actions]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Accepted, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[bruno-garcia]

Closed in favor of: #23868