feat: java grouping improvements #23868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
changed the title
bruno-garcia
commented
Feb 14, 2021
| @@ -31,3 +31,11 @@ family:native function:"?[[]SentryClient *" -app -group | |||
| family:native function:"?[[]SentryHub *" -app -group | |||
| family:native function:"?[[]RNSentry *" -app -group | |||
| family:native function:"?[[]SentrySDK *" -app -group | |||
|
|
|||
| # Java | |||
There was a problem hiding this comment.
I'm assuming I should revert this
| frame* (frame considered in-app because no frame is in-app) | ||
| app | ||
| stacktrace | ||
| frame (ignored by stack trace rule (family:java module:*.reflect.GeneratedConstructorAccessor* -app -group)) |
There was a problem hiding this comment.
Should I revert this rule because it's already baked in somehow?
bruno-garcia
force-pushed
the
feat/java-grouping-improvements
branch
from
8a24899
to
8b6c437
Compare
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Comment on lines
+67
to
+68
| # Match $$EnhancerByGuice$$ and $$FastClassByGuice$$ with a single rule: | ||
| family:java module:*ByGuice$$* -app -group |
There was a problem hiding this comment.
Would be nice to have rules for spring CGLIB as well:
|
This is pretty stale. cc @adinauer in case you want to take this over |
|
@bruno-garcia some of those should already be fixed via #45185 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: #22953
Resolves: getsentry/sentry-java#1018
Resolves: #18959
Resolves: #21645