feat(notifications): member invite slack requests #29708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-invite-slack-requests
ceorourke
approved these changes
Nov 3, 2021
tests/sentry/api/endpoints/test_organization_invite_request_index.py
Outdated
Show resolved
Hide resolved
tests/sentry/api/endpoints/test_organization_invite_request_index.py
Outdated
Show resolved
Hide resolved
|
|
||
| @responses.activate | ||
| @with_feature("organizations:slack-requests") | ||
| def test_request_to_join_slack(self): |
There was a problem hiding this comment.
For the email one I notice you check that it sends 2 (one to the manager and one to the owner), is it expected to notify both on Slack as well?
There was a problem hiding this comment.
@ceorourke yep, but I'm not checking that spec here since it's the same
| @@ -1,72 +0,0 @@ | |||
| from django.urls import reverse | |||
There was a problem hiding this comment.
I think you need to remove sentry.tasks.members from server.py too cause this is making stuff angery
mgaeta
reviewed
Nov 3, 2021
scefali
added a commit
that referenced
this pull request
Nov 8, 2021
…_details (#29823) This PR pulls out some helper methods from `OrganizationInviteRequestDetailsEndpoint` such that we can leverage common code with an [upcoming PR](#29708) that allows approving member requests with Slack. This is necessary so we can avoid calling the `OrganizationInviteRequestDetailsEndpoint` endpoint internally from the Slack webhook route while reducing the amount of duplicated code. I had to factor out an audit log method that does not require a request so that we can call it from a context that doesn't have a request coming from a logged-in user (Slack webhook). Note I made a utility file called `src/sentry/utils/members.py` but it might make more sense to move those methods to the `OrganizationMember` class.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Slack notifications to the member invitation and join requests hidden behind the
organizations:slack-requestsfeature flag:Once a user accepts or rejects the request, we update the message: