feat(onboarding): remove welcome page experiment and use new experience #33616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scefali
commented
Apr 14, 2022
| platform: PlatformKey | null; | ||
| project: Project | null; | ||
| organization?: Organization; |
There was a problem hiding this comment.
I'm not sure why organization was marked as optional as it makes typing more difficult and the parent component has organization as required. So I just made it required.
| it('renders', function () { | ||
| const name = 'Rick Snachez'; | ||
| const name = 'Rick Sanchez'; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copies the welcome page component from the targeted onboarding flow into the default onboarding flow and removes the
TargetedOnboardingWelcomePageExperimentV2experiment. There are some minor differences to handle the different prop types but everything else is the same.Since we only have one welcome background now, I was able to delete the one from the targeted onboarding folder and just copy its contents to the shared one.
Here's what it looks like now:
