fix(avatarChooser): Handle submit without selecting file #38190 #38191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gracefully handle when a user has not selected any file and tries to save Avatar. While it is handled in backend but also there is need to display error message at frontend. Fixes #38190
github-actions
bot
added
the
Scope: Frontend
|
How about instead we make it so the button is just disabled if you haven't selected anything? |
Now save avatar button will disabled if user has not selected any file. |
Gracefully handle when a user has not selected any file and tries to save Avatar. While it is handled in backend but also there is need to disable save button at frontend. 8038494#r968967137 Fixes #38190
|
/gcbrun |
|
This looks good, let me make sure all the test are passing and I think we're good to go! |
evanpurkhiser
added
the
Trigger: getsentry tests
github-actions
bot
removed
the
Trigger: getsentry tests
|
@evanpurkhiser looks like merging is blocked, can you please suggest if something pending from my side ? |
evanpurkhiser
added
the
Trigger: getsentry tests
|
/gcbrun |
|
@evanpurkhiser , can you please merge if everything is ok. |
|
Sorry again for the delay! Will get this merged today! |
github-actions
bot
removed
the
Trigger: getsentry tests
evanpurkhiser
approved these changes
Sep 27, 2022
evanpurkhiser
added
the
Trigger: getsentry tests
|
/gcbrun |
ryan953
pushed a commit
that referenced
this pull request
Oct 3, 2022
chadwhitacre
removed
the
Trigger: getsentry tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gracefully handle when a user has not selected any file and tries to save Avatar.
While it is handled in backend but also there is need to display error message at frontend.
Fixes #38190
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.