feat(sidebar): open up broadcasts if #whats-new is the hash #38838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Comment on lines
94
to
98
| useEffect(() => { | ||
| if (location?.hash === '#whats-new') { | ||
| togglePanel(SidebarPanelKey.Broadcasts); | ||
| } | ||
| }, [location?.hash]); |
There was a problem hiding this comment.
Want to generalize it be
type SidebarHash = `#sidebar-${SidebarPanelKey}`;and then you can parse the string and toggle whatever with #sidebar-whats-new
There was a problem hiding this comment.
@evanpurkhiser good call
evanpurkhiser
approved these changes
Sep 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to send links to Sentry with the "What's new" section opened. We can do this with a hash parameter
#sidebar-broadcasts.