test(ui): Convert DropdownLink tests to RTL and TS #39322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
| }); | ||
|
|
||
| it('does not close when document is clicked', function () { | ||
| jest.useFakeTimers(); |
There was a problem hiding this comment.
would it be fine if instead of using jest.useFakeTimers and jest.runAllTimers(), we would just wait for the element by using await screen.find*?
There was a problem hiding this comment.
We still want to use jest.useFakeTimers() so the test can finish as fast as possible, but I just learned that the async utilities do advance fake timers which is great: testing-library/dom-testing-library#661
So I kept the fake timers and removed all the runAllTimers() calls
scttcper
approved these changes
Sep 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.