Notify owners about organization deletion #4116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobenolt
force-pushed
the
restore-org
branch
3 times, most recently
from
c9945c7
to
6b4d0a2
Compare
| def get_owners(self): | ||
| from sentry.models import User | ||
| return User.objects.filter( | ||
| sentry_orgmember_set__role=roles.get_top_dog().id, |
|
My stab at copy with one clear action that will work in both the app and email: Organization queued for deletionThe Sentry organization has been scheduled for deletion by: This irreversible deletion will take place at Sept. 10, 2016, 11:46 p.m. and will permanently remove all associated data including events, projects, and team members. If this was unintentional and you would like to cancel the deletion:[Restore Organization] |
| event=AuditLogEntryEvent.ORG_RESTORE, | ||
| data=organization.get_audit_log_data(), | ||
| ) | ||
| delete_logger.info('object.delete.canceled', extra={ |
There was a problem hiding this comment.
TIL it's normal to have both canceled and cancelled in English.
|
Reviewed 8 of 12 files at r1. Comments from Reviewable |
mattrobenolt
force-pushed
the
restore-org
branch
5 times, most recently
from
683dd8e
to
d2f7156
Compare
mattrobenolt
changed the title
mattrobenolt
force-pushed
the
restore-org
branch
from
d2f7156
to
7362368
Compare
|
Alright, tests have been written, and removed "WIP" tag. :) |
mattrobenolt
force-pushed
the
restore-org
branch
from
7362368
to
da3dd05
Compare
|
fix yo linters yo |
And prompt them to cancel and restore the organization.
mattrobenolt
force-pushed
the
restore-org
branch
from
da3dd05
to
d763823
Compare
|
@dcramer fixed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And prompt them to cancel and restore the organization.
@getsentry/infrastructure @getsentry/ui
Help on messaging here would be nice since what I put is likely garbage.
Web UI:
Email:
TODO:
This change is