fix(stacketrace-link): Fix tagging and tag early adopters #41648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: * `stacktrace_link.found` is containing the wrong value * All code mappings are tried even if `config.stack_root` does not match Changes: * Tag if the organization is an `early_adopter`
Changes: * fix: `stacktrace_link.found` is storing the wrong value * feature: Tag early adopter organizations
armenzg
added this to the Dervided Code Mappings (GA Release - JS and Python) milestone
armenzg
commented
Nov 22, 2022
| scope.set_tag("project.slug", project.slug) | ||
| scope.set_tag("organization.slug", project.organization.slug) | ||
| try: | ||
| scope.set_tag("organization.early_adopter", project.organization.flags.early_adopter) |
There was a problem hiding this comment.
This is the new addition.
| scope.set_tag("organization.early_adopter", project.organization.flags.early_adopter) | ||
| except Exception: | ||
| # If errors arise we can then follow up with a fix | ||
| logger.exception("We failed to set the early adopter flag") |
There was a problem hiding this comment.
If this was to cause errors I would see it and then fix it.
| @@ -95,7 +108,7 @@ class ProjectStacktraceLinkEndpoint(ProjectEndpoint): | |||
| users can go from the file in the stack trace to the | |||
| provider of their choice. | |||
|
|
|||
| `filepath`: The file path from the stack trace | |||
| `file`: The file path from the stack trace | |||
There was a problem hiding this comment.
The parameter the UI uses is file rather than filepath.
| @@ -166,7 +178,7 @@ def get(self, request: Request, project) -> Response: | |||
| break | |||
|
|
|||
| # Post-processing before exiting scope context | |||
| found = result.get("sourceUrl") | |||
| found: bool = result["sourceUrl"] is not None | |||
There was a problem hiding this comment.
We were storing the URL rather than a boolean.
github-actions
bot
added
the
Scope: Backend
NisanthanNanthakumar
approved these changes
Nov 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
stacktrace_link.foundis storing the wrong value