fix(project options): Store feedback:branding options correctly #42022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
It looks like this change was made recently in #39575 so cc @cathyteng17 and @markstory |
wedamija
approved these changes
Dec 5, 2022
wedamija
reviewed
Dec 5, 2022
| @@ -184,7 +184,7 @@ def format_options(attrs: defaultdict(dict)): | |||
| f"filters:{FilterTypes.ERROR_MESSAGES}": "\n".join( | |||
| attrs["options"].get(f"sentry:{FilterTypes.ERROR_MESSAGES}", []) | |||
| ), | |||
| "feedback:branding": attrs.get("feedback:branding", "1") == "1", | |||
| "feedback:branding": attrs["options"].get("feedback:branding", "1") == "1", | |||
There was a problem hiding this comment.
I can't comment on it, but is "sentry:reprocessing_active": bool(attrs.get("sentry:reprocessing_active", False)), also broken?
There was a problem hiding this comment.
Maybe we should do
options = attrs["options"]
....
options.get(...)
Might be less error prone
There was a problem hiding this comment.
i think you're right (on both counts)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wedamija
approved these changes
Dec 5, 2022
dashed
approved these changes
Dec 5, 2022
markstory
approved these changes
Dec 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toggling off the user feedback branding option wasn't actually doing anything - when the user refreshed the screen it was back to "on". This PR fixes that by grabbing the option correctly - before it was always falling back to the default value and setting it to True.