Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove the bookmarks filter if anon user #398 #444
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
heynemann
Apr 23, 2013
Contributor
This seems like a good pull request. Sentry should never 500.
Any idea on why this hasn't been merged?
|
This seems like a good pull request. Sentry should never 500. Any idea on why this hasn't been merged? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
I believe you have to be logged in now anyways so this is invalid |
dcramer
closed this
Apr 23, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
robcowie commentedApr 21, 2012
Attempting to filter by bookmarks when not logged in currently fails hard (see #398)
This patch removes the "Only Bookmarks" link from the sidebar, and ignores
?bookmarks=1if the user is anonymous.I'm not convinced removing the link makes for a good UX. Perhaps disabling it in some way is a better option. Let me know what you guys prefer and I'll modify accordingly.