Remove the bookmarks filter if anon user #398 #444

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@robcowie

Attempting to filter by bookmarks when not logged in currently fails hard (see #398)

This patch removes the "Only Bookmarks" link from the sidebar, and ignores ?bookmarks=1 if the user is anonymous.

I'm not convinced removing the link makes for a good UX. Perhaps disabling it in some way is a better option. Let me know what you guys prefer and I'll modify accordingly.

Remove the bookmarks filter is anon user #398
* Remove the "Only Bookmarks" filter from the sidebar
* Ignore ?bookmarks=1 if anon user
@heynemann

This comment has been minimized.

Show comment Hide comment
@heynemann

heynemann Apr 23, 2013

Contributor

This seems like a good pull request. Sentry should never 500.

Any idea on why this hasn't been merged?

Contributor

heynemann commented Apr 23, 2013

This seems like a good pull request. Sentry should never 500.

Any idea on why this hasn't been merged?

@dcramer

This comment has been minimized.

Show comment Hide comment
@dcramer

dcramer Apr 23, 2013

Owner

I believe you have to be logged in now anyways so this is invalid

Owner

dcramer commented Apr 23, 2013

I believe you have to be logged in now anyways so this is invalid

@dcramer dcramer closed this Apr 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment