populate release organizations and projects #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobenolt
reviewed
Dec 3, 2016
| qs = orm.Release.objects.all().select_related('project') | ||
| for r in RangeQuerySetWrapperWithProgressBar(qs): | ||
| r.organization_id = r.project.organization_id | ||
| r.save() |
There was a problem hiding this comment.
Change this to:
orm.Release.objects.filter(id=r.id).update(organization_id=r.project.organization_id)
mattrobenolt
reviewed
Dec 3, 2016
|
|
||
| def backwards(self, orm): | ||
| "Write your backwards methods here." | ||
| for r in orm.Release.objects.all(): |
There was a problem hiding this comment.
tbh I'd just remove this. There's literally no rolling back ever.
macqueen
force-pushed
the
org-releases
branch
from
ba9540c
to
d86c5af
Compare
macqueen
force-pushed
the
org-releases-2
branch
2 times, most recently
from
292d67b
to
8cd7146
Compare
macqueen
force-pushed
the
org-releases-2
branch
from
8cd7146
to
9591772
Compare
Generated by 🚫 danger |
use update in migration, remove backwards migration
macqueen
force-pushed
the
org-releases-2
branch
from
9591772
to
74f15f9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relies on #4627 (will switch to merge into master once that pr has been merged)
cc @benvinegar @kjlundsgaard