feat(escalating-issues): Add ARCHIVE_UNTIL_ESCALATING to GroupHistory #47437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47437 +/- ##
==========================================
- Coverage 80.75% 78.23% -2.52%
==========================================
Files 4762 4762
Lines 201425 201421 -4
Branches 11618 11618
==========================================
- Hits 162654 157575 -5079
- Misses 38515 43590 +5075
Partials 256 256
|
snigdhas
commented
Apr 17, 2023
Comment on lines
-152
to
-169
| class GroupSubStatus: | ||
| # GroupStatus.IGNORED | ||
| UNTIL_ESCALATING = 1 | ||
|
|
||
| # GroupStatus.UNRESOLVED | ||
| ESCALATING = 2 | ||
| ONGOING = 3 | ||
|
|
||
|
|
||
| UNRESOLVED_SUBSTATUS_CHOICES = { | ||
| GroupSubStatus.ONGOING, | ||
| GroupSubStatus.ESCALATING, | ||
| } | ||
|
|
||
| IGNORED_SUBSTATUS_CHOICES = { | ||
| GroupSubStatus.UNTIL_ESCALATING, | ||
| } | ||
|
|
There was a problem hiding this comment.
Moving the GroupSubStatus types to sentry/types
snigdhas
force-pushed
the
snigdha/add-arch-gh
branch
from
2a16805
to
0eac1b3
Compare
Comment on lines
+7
to
+8
| from sentry.models.group import STATUS_UPDATE_CHOICES | ||
| from sentry.types.group import SUBSTATUS_UPDATE_CHOICES |
There was a problem hiding this comment.
I don't know our conventions, but is it weird that one of these lives in the model and one lives in the types module?
There was a problem hiding this comment.
Yeah, I don't like that split either - I can look at rehoming the GroupStatus + related types in a followup PR. Had to move the GroupSubStatus because of a circular dependency
lobsterkatie
approved these changes
Apr 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOR-2835, WOR-2964