Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix migrations for dropping not null constraint on release project #4757

Merged
merged 4 commits into from
Jan 12, 2017

Conversation

macqueen
Copy link
Contributor

No description provided.

@getsentry-bot
Copy link
Contributor

getsentry-bot commented Jan 12, 2017

2 Warnings
⚠️ Changes require @getsentry/security sign-off
⚠️ Big PR – consider splitting it up into multiple changesets

Security concerns found

  • src/sentry/web/frontend/debug/debug_new_release_email.py

Generated by 🚫 danger

@@ -724,7 +699,7 @@ def backwards(self, orm):
'id': ('sentry.db.models.fields.bounded.BoundedBigAutoField', [], {'primary_key': 'True'}),
'is_verified': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
'user': ('sentry.db.models.fields.foreignkey.FlexibleForeignKey', [], {'related_name': "'emails'", 'to': "orm['sentry.User']"}),
'validation_hash': ('django.db.models.fields.CharField', [], {'default': "u'R6zOiWKMO0GUE2e6HGMyFwPxDqc7hR7E'", 'max_length': '32'})
'validation_hash': ('django.db.models.fields.CharField', [], {'default': "u'8g5HTkl1az1PBdiGQi2Ekji7kGyTFL9J'", 'max_length': '32'})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol this is actually bad, this is a bug in our side that has somehow never caused a problem

Copy link
Contributor

@mattrobenolt mattrobenolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💸

@macqueen macqueen merged commit 08f3e24 into master Jan 12, 2017
@macqueen macqueen deleted the fix-things-maybe branch January 12, 2017 23:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants