Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exception-group): Add new mechanism fields to Exception interface #47643

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

malwilley
Copy link
Member

Mirrors the properties added in getsentry/relay#2020

Without this change the event endpoints will strip these values.

@malwilley malwilley requested review from mattjohnsonpint and a team April 19, 2023 16:27
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #47643 (149742c) into master (5b1edbc) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #47643      +/-   ##
==========================================
- Coverage   80.76%   80.52%   -0.24%     
==========================================
  Files        4765     4763       -2     
  Lines      201451   201243     -208     
  Branches    11617    11617              
==========================================
- Hits       162699   162058     -641     
- Misses      38496    38929     +433     
  Partials      256      256              
Impacted Files Coverage Δ
static/app/components/actions/resolve.tsx 68.85% <ø> (+1.66%) ⬆️
static/app/components/modals/commandPalette.tsx 100.00% <ø> (ø)
...nents/modals/dashboardWidgetQuerySelectorModal.tsx 95.23% <ø> (+4.32%) ⬆️
static/app/components/modals/demoEndModal.tsx 60.00% <ø> (+2.37%) ⬆️
static/app/components/modals/demoSignUp.tsx 0.00% <ø> (ø)
...app/components/modals/inviteMembersModal/index.tsx 92.91% <ø> (+0.54%) ⬆️
...modals/savedSearchModal/createSavedSearchModal.tsx 79.16% <ø> (-0.84%) ⬇️
...atic/app/components/modals/suggestProjectModal.tsx 65.78% <ø> (+4.81%) ⬆️
static/app/components/modals/widgetViewerModal.tsx 77.68% <ø> (+0.48%) ⬆️
...modals/widgetViewerModal/widgetViewerTableCell.tsx 75.36% <ø> (-1.03%) ⬇️
... and 37 more

... and 35 files with indirect coverage changes

@malwilley malwilley merged commit f444d8a into master Apr 19, 2023
@malwilley malwilley deleted the malwilley/feat/exception-interface-mechanism branch April 19, 2023 18:26
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants