feat(exception-group): Auto-collapse child exception groups #48527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
force-pushed
the
malwilley/feat/exceptiongroup-hide-children
branch
from
25f4a78
to
96767e7
Compare
malwilley
force-pushed
the
malwilley/feat/exceptiongroup-hide-children
branch
from
96767e7
to
2e51911
Compare
mattjohnsonpint
approved these changes
May 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47828
To prevent the stack trace from becoming too long and unwieldy, this collapses child exception groups. This means that only the first level of the tree is visible at first, but the user may expand them by clicking "Show n related exceptions" or clicking the element in the exception tree.
Can test on this issue: https://sentry-sdks.dev.getsentry.net:7999/issues/4126628864/events/e303031f97ab4b25b0f275d41a35a323/?project=5428537
CleanShot.2023-05-04.at.09.00.05.mp4