chore(starfish): Remove the count if query #49097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
edwardgou-sentry
approved these changes
May 15, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49097 +/- ##
==========================================
- Coverage 80.92% 80.92% -0.01%
==========================================
Files 4819 4819
Lines 202008 202014 +6
Branches 11412 11412
==========================================
+ Hits 163469 163472 +3
- Misses 38285 38288 +3
Partials 254 254
|
volokluev
pushed a commit
that referenced
this pull request
May 30, 2023
Remove the count_if, it's much slower than I anticipated, will add it back as a "regression" in a few hours
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the count_if, it's much slower than I anticipated,
will add it back as a "regression" in a few hours