Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Go to the profiling wizard #51050

Merged
merged 1 commit into from
Jun 16, 2023
Merged

feat: add Go to the profiling wizard #51050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions static/app/components/profiling/ProfilingOnboarding/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export const supportedPlatformExpectedDocKeys: Record<
'3-configure-profiling',
'4-upload',
],
go: ['0-alert', '1-install', '2-configure-performance', '3-configure-profiling'],
node: ['1-install', '2-configure-performance', '3-configure-profiling'],
python: ['1-install', '2-configure-performance', '3-configure-profiling'],
php: ['1-install', '2-configure-performance', '3-configure-profiling'],
Expand Down
2 changes: 2 additions & 0 deletions static/app/data/platformCategories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,8 @@ export const profiling: PlatformKey[] = [
// mobile
'android',
'apple-ios',
// go
'go',
// nodejs
'node',
'node-express',
Expand Down
7 changes: 7 additions & 0 deletions static/app/utils/profiling/platforms.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export const supportedProfilingPlatforms = profiling;
export const supportedProfilingPlatformSDKs = [
'android',
'apple-ios',
'go',
'node',
'python',
'php',
Expand Down Expand Up @@ -36,6 +37,12 @@ export function getDocsPlatformSDKForPlatform(
if (platform === 'apple-ios') {
return 'apple-ios';
}

// Go
if (platform === 'go') {
return 'go';
}

// Javascript
if (platform.startsWith('node')) {
return 'node';
Expand Down