feat(issue-details): Improved UI for viewing object/array values #66153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
force-pushed
the
malwilley/feat/structured-data-obj-array-ui
branch
from
f4dcaf9
to
1b1c7c7
Compare
malwilley
force-pushed
the
malwilley/feat/structured-data-obj-array-ui
branch
from
1b1c7c7
to
5a3efae
Compare
|
Can we make the toggles less prominent (perhaps with just the icon and no button formatting) and only appear on hover? |
scttcper
reviewed
Mar 1, 2024
| depth, | ||
| maxDefaultDepth, | ||
| }: CollapsibleValueProps) { | ||
| const numChildren = Children.count(children); |
There was a problem hiding this comment.
|
@vuluongj20 agree that the toggle buttons make it look a bit busy. Went ahead and removed the background and border, it looks like this (a lot better!):
I tried hiding the buttons until hover, but it left gaps that didn't look very good:
IMO keeping the buttons all the time isn't so bad now that they are less emphasized. What do you think? |
scttcper
approved these changes
Mar 2, 2024
…ctured-data-obj-array-ui
|
Ahh yea I agree with you about the gaps. Let's merge the current version then! 🚀 |
vuluongj20
approved these changes
Mar 6, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
aliu3ntry
pushed a commit
that referenced
this pull request
Mar 6, 2024
) Fixes #58573, #48480 Previously, objects/arrays were only collapsible after they reached maxDefaultDepth. The major change here is that now each level is collapsible - Each level is now always collapsible. Before, objects/arrays were only collapsible after a certain depth - Arrays/objects begin collapsed when there are more than 5 items, in addition to when they are at a certain depth - Changed the appearance and location of the toggle buttons to better match commonly-used json viewers - Added `n items` preview text for collapsed objects/arrays (which is clickable!)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58573, #48480
Previously, objects/arrays were only collapsible after they reached maxDefaultDepth. The major change here is that now each level is collapsible
n itemspreview text for collapsed objects/arrays (which is clickable!)Before:
After:
And here's an example of the new auto-collapse behavior helping out when context values are very large: