test(ui): Vendor react-select-event, use user events
#66441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the library [react-select-event](https://github.com/lokalise/react-select-event) this adds the one file and switches it from fireEvent to userEvent. User Event properly awaits and wraps events in `act` to prevent act warnings with react 18. Changes: - `openMenu` is now async because `userEvent.click` is async - Tests that did `selectEvent.openMenu` and then `selectEvent.select` were switched to just `selectEvent.openMenu` and `userEvent.click` since select tries to click the dropdown button again which means it's closed. Somehow it was fast enough before to select something before the menu closed? part of getsentry/frontend-tsc#22
github-actions
bot
added
the
Scope: Frontend
scttcper
commented
Mar 6, 2024
| @@ -0,0 +1,184 @@ | |||
| // From https://github.com/romgain/react-select-event | |||
| // | |||
| // Copyright 2019 Romain Bertrand | |||
There was a problem hiding this comment.
evanpurkhiser
approved these changes
Mar 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the library react-select-event this adds the one file and switches it from fireEvent to userEvent. User Event properly wraps each event in
actwhich prevents act warnings in react 18.Changes:
openMenuis now async becauseuserEvent.clickis asyncselectEvent.openMenuand thenselectEvent.selectwere switched to justselectEvent.openMenuanduserEvent.clicksince select tries to click the dropdown button again which means it's closed. Somehow it was fast enough before to select something before the menu closed?part of https://github.com/getsentry/frontend-tsc/issues/22