ref(crons): Clarify why incident creation skip happens #66462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
evanpurkhiser
commented
Mar 6, 2024
| @@ -138,22 +138,25 @@ def mark_failed_threshold(failed_checkin: MonitorCheckIn, failure_issue_threshol | |||
| monitor_env.status = MonitorStatus.ERROR | |||
| monitor_env.save(update_fields=("status",)) | |||
|
|
|||
| # Do not create incident if monitor is muted | |||
| if not monitor_muted: | |||
There was a problem hiding this comment.
Pulled this into a guard statment
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66462 +/- ##
=======================================
Coverage 84.29% 84.29%
=======================================
Files 5308 5310 +2
Lines 237214 237263 +49
Branches 41036 41036
=======================================
+ Hits 199965 200012 +47
- Misses 37030 37032 +2
Partials 219 219
|
davidenwang
approved these changes
Mar 6, 2024
evanpurkhiser
deleted the
evanpurkhiser/ref-crons-clarify-why-incident-creation-skip-happens
branch
aliu3ntry
pushed a commit
that referenced
this pull request
Mar 6, 2024
Guard statments tend to be clearer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard statments tend to be clearer