-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed cardinality limiting from indexer #67535
Conversation
b48e647
to
4ec40f1
Compare
Do we still need |
Agreed. Do we still need the entrypoints in |
Cool, maybe let's test this locally to verify that things are working before. Let's test end to end, locally, that metrics are successfully ingested and queryable, by running the indexer and relevant Snuba consumers and ensure we see all metric types (dist, set, gauge, counter) in both Postgres and Clickhouse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Relay already applies cardinality limits, so we can safely remove cardinality limiting from the indexer
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.