Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed cardinality limiting from indexer #67535

Merged
merged 5 commits into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions src/sentry/sentry_metrics/consumers/indexer/processing.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
ReleaseHealthTagsValidator,
)
from sentry.sentry_metrics.indexer.base import StringIndexer
from sentry.sentry_metrics.indexer.limiters.cardinality import cardinality_limiter_factory
from sentry.sentry_metrics.indexer.mock import MockIndexer
from sentry.sentry_metrics.indexer.postgres.postgres_v2 import PostgresIndexer
from sentry.utils import metrics, sdk
Expand Down Expand Up @@ -126,19 +125,6 @@ def _process_messages_impl(

sdk.set_measurement("indexer_batch.payloads.len", len(batch.parsed_payloads_by_meta))

with metrics.timer("metrics_consumer.check_cardinality_limits"), sentry_sdk.start_span(
op="check_cardinality_limits"
):
cardinality_limiter = cardinality_limiter_factory.get_ratelimiter(self._config)
cardinality_limiter_state = cardinality_limiter.check_cardinality_limits(
self._config.use_case_id, batch.parsed_payloads_by_meta
)

sdk.set_measurement(
"cardinality_limiter.keys_to_remove.len", len(cardinality_limiter_state.keys_to_remove)
)
batch.filter_messages(cardinality_limiter_state.keys_to_remove)

extracted_strings = batch.extract_strings()

sdk.set_measurement("org_strings.len", len(extracted_strings))
Expand All @@ -153,10 +139,4 @@ def _process_messages_impl(

sdk.set_measurement("new_messages.len", len(results.data))

with metrics.timer("metrics_consumer.apply_cardinality_limits"), sentry_sdk.start_span(
op="apply_cardinality_limits"
):
# TODO: move to separate thread
cardinality_limiter.apply_cardinality_limits(cardinality_limiter_state)

return results
208 changes: 0 additions & 208 deletions src/sentry/sentry_metrics/indexer/limiters/cardinality.py

This file was deleted.

Loading
Loading