Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proguard): A/B test new Symbolicator implementation #67784

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

loewenheim
Copy link
Contributor

Based upon #66764.

This adds a new rate option "symbolicator.proguard-processing-ab-test" that causes proguard events to be processed using Symbolicator in addition to the existing Python method and the results to be diffed.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 27, 2024
@loewenheim loewenheim self-assigned this Mar 27, 2024
Base automatically changed from proguard/processing to master March 28, 2024 10:45
@loewenheim loewenheim requested review from a team March 28, 2024 10:45
@loewenheim loewenheim requested review from a team as code owners March 28, 2024 10:45
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. though this needs a rebase on master :-)

src/sentry/lang/java/plugin.py Outdated Show resolved Hide resolved
src/sentry/lang/java/plugin.py Outdated Show resolved Hide resolved
@loewenheim loewenheim merged commit b34eaf0 into master Apr 3, 2024
48 of 49 checks passed
@loewenheim loewenheim deleted the proguard/ab-testing branch April 3, 2024 10:08
Copy link

sentry-io bot commented Apr 8, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AttributeError: 'NoneType' object has no attribute 'get' sentry.tasks.store.process_event View Issue
  • ‼️ TypeError: 'NoneType' object is not subscriptable sentry.tasks.store.process_event View Issue
  • ‼️ TypeError: 'NoneType' object is not iterable sentry.tasks.store.process_event View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants