Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate(related_issues): Drop support for doing all types of related issues #70793

Merged
merged 3 commits into from
May 14, 2024

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented May 13, 2024

This is a follow-up to #70504. Once the UI stops using this approach we will merge this change.

This got temporarily reverted in #70606 since we had to revert the UI PR.

…d issues

This is a follow up to #70504. Once the UI stops using this approach we will merged this change.
@armenzg armenzg self-assigned this May 13, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 13, 2024
@armenzg armenzg marked this pull request as ready for review May 13, 2024 18:38
@armenzg armenzg requested a review from a team as a code owner May 13, 2024 18:38
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.03%. Comparing base (9c8f38e) to head (1e3a301).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #70793      +/-   ##
==========================================
+ Coverage   80.00%   80.03%   +0.02%     
==========================================
  Files        6507     6504       -3     
  Lines      290809   290575     -234     
  Branches    50125    50090      -35     
==========================================
- Hits       232669   232568     -101     
+ Misses      57704    57570     -134     
- Partials      436      437       +1     
Files Coverage Δ
src/sentry/api/endpoints/issues/related_issues.py 100.00% <100.00%> (+8.33%) ⬆️
src/sentry/issues/related/__init__.py 100.00% <ø> (+41.66%) ⬆️

... and 153 files with indirect coverage changes

@armenzg armenzg merged commit ff87f5e into master May 14, 2024
49 checks passed
@armenzg armenzg deleted the feat/deprecate-old-approach/related_issues/armenzg branch May 14, 2024 13:38
Copy link

sentry-io bot commented May 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ MultiValueDictKeyError: 'type' /api/0/issues/{issue_id}/related-issues/ View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants