feat(related_issues): Decouple endpoint #70504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #70504 +/- ##
===========================================
+ Coverage 56.59% 79.97% +23.37%
===========================================
Files 6491 6502 +11
Lines 289896 290444 +548
Branches 49965 50036 +71
===========================================
+ Hits 164071 232273 +68202
+ Misses 125453 57804 -67649
+ Partials 372 367 -5
|
mrduncan
approved these changes
May 8, 2024
The API would try extracting issues with the same root cause and from the trace, this is done sequentially (slower) and it makes it harder to iterate on each approach indepdently. This change allows using a `type` parameter with the endpoint in order to execute one approach or the other. The UI will be changed to make two independent requests, thus, improving load time.
Co-authored-by: Matt Duncan <14761+mrduncan@users.noreply.github.com>
github-actions
bot
added
the
Scope: Frontend
This comment was marked as outdated.
This comment was marked as outdated.
armenzg
force-pushed
the
feat/related_issues/decouple_endpoint/armenzg
branch
from
11277e4
to
adcb389
Compare
armenzg
added a commit
that referenced
this pull request
May 9, 2024
…d issues This is a follow up to #70504. Once the UI stops using this approach we will merged this change.
armenzg
added a commit
that referenced
this pull request
May 10, 2024
In #70504 I added support for the `type` parameter which allows getting separately the data for same-root issues vs trace-connected issues. This UI change allows each related issues section to fetch and render the data independently, thus, making the page load faster. These changes are required in order to support just fetching trace-connected issues from the Issues Details page.
armenzg
added a commit
that referenced
this pull request
May 13, 2024
…#70648) In #70504 I added support for the `type` parameter which allows getting the data for same-root issues vs trace-connected issues separately. This UI change allows each related issues section to fetch and render the data independently, thus, making the page load faster. These changes are required to support fetching trace-connected issues from the Issues Details page without also fetching same-root-connected data.
armenzg
added a commit
that referenced
this pull request
May 13, 2024
…d issues This is a follow up to #70504. Once the UI stops using this approach we will merged this change.
armenzg
added a commit
that referenced
this pull request
May 14, 2024
…#70789) In #70504 I added support for the type parameter which allows getting the data for same-root issues vs trace-connected issues separately. This UI change allows each related issues section to fetch and render the data independently, thus, making the page load faster. These changes are required to support fetching trace-connected issues from the Issues Details page without also fetching same-root-connected data. --------- Co-authored-by: Scott Cooper <scttcper@gmail.com> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API tries to find issues for both approaches sequentially (slower), making it harder to iterate on each approach independently.
This change allows using a
typeparameter with the endpoint to execute one approach or the other.The UI will be changed to make two independent requests, thus, improving load time.
This is required to empower trace issues from the issues details page.