Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crons): Add processing errors to monitor listing page #71419

Merged
merged 2 commits into from
May 23, 2024

Conversation

davidenwang
Copy link
Member

image

@davidenwang davidenwang requested a review from a team as a code owner May 22, 2024 23:20
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 22, 2024
Copy link

codecov bot commented May 22, 2024

Bundle Report

Changes will increase total bundle size by 1.29kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 27.57MB 1.29kB ⬆️

Comment on lines 69 to 73
const {data: processingErrors, isLoading: loadingProcessingErrors} = useApiQuery<
CheckinProcessingError[]
>(processingErrorQueryKey, {
staleTime: 0,
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need the loading state?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh we do not good catch

Base automatically changed from davidenwang/generalize-processing-error to master May 23, 2024 20:40
@davidenwang davidenwang force-pushed the davidenwang/processing-errors-monitor-overview branch from 03af35f to e447e2f Compare May 23, 2024 20:56
@davidenwang davidenwang enabled auto-merge (squash) May 23, 2024 20:56
@davidenwang davidenwang merged commit 3e1ee26 into master May 23, 2024
40 of 41 checks passed
@davidenwang davidenwang deleted the davidenwang/processing-errors-monitor-overview branch May 23, 2024 21:06
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants