-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crons): Add processing errors to monitor listing page #71419
Merged
davidenwang
merged 2 commits into
master
from
davidenwang/processing-errors-monitor-overview
May 23, 2024
Merged
feat(crons): Add processing errors to monitor listing page #71419
davidenwang
merged 2 commits into
master
from
davidenwang/processing-errors-monitor-overview
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidenwang
commented
May 22, 2024
github-actions
bot
added
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
May 22, 2024
Bundle ReportChanges will increase total bundle size by 1.29kB ⬆️
|
evanpurkhiser
approved these changes
May 23, 2024
Comment on lines
69
to
73
const {data: processingErrors, isLoading: loadingProcessingErrors} = useApiQuery< | ||
CheckinProcessingError[] | ||
>(processingErrorQueryKey, { | ||
staleTime: 0, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we even need the loading state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh we do not good catch
Base automatically changed from
davidenwang/generalize-processing-error
to
master
May 23, 2024 20:40
davidenwang
force-pushed
the
davidenwang/processing-errors-monitor-overview
branch
from
May 23, 2024 20:56
03af35f
to
e447e2f
Compare
volokluev
pushed a commit
that referenced
this pull request
May 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.