Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hybridcloud) Switch to undeprecated integration RPC methods #71445

Merged
merged 2 commits into from
May 24, 2024

Conversation

markstory
Copy link
Member

Follow up to #71433 and part of the work to remove tuples from RPC method signatures.

Refs HC-1190

Follow up to #71433 and part of the work to remove tuples from RPC
method signatures.

Refs HC-1190
@markstory markstory requested review from a team as code owners May 23, 2024 16:28
@markstory markstory requested a review from a team May 23, 2024 16:28
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes are missing coverage. Please review.

Please upload report for BASE (master@0c8b7f9). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Current head d806202 differs from pull request most recent head d0e03b4

Please upload reports for the commit d0e03b4 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #71445   +/-   ##
=========================================
  Coverage          ?   77.92%           
=========================================
  Files             ?     6533           
  Lines             ?   290956           
  Branches          ?    50343           
=========================================
  Hits              ?   226713           
  Misses            ?    58002           
  Partials          ?     6241           
Files Coverage Δ
src/sentry/api/bases/organization_integrations.py 78.72% <100.00%> (ø)
.../sentry/api/endpoints/group_integration_details.py 75.00% <100.00%> (ø)
src/sentry/incidents/logic.py 90.08% <100.00%> (ø)
src/sentry/integrations/github/webhook.py 74.76% <100.00%> (ø)
src/sentry/integrations/gitlab/webhooks.py 86.48% <100.00%> (ø)
src/sentry/integrations/jira/utils/api.py 86.15% <100.00%> (ø)
src/sentry/integrations/opsgenie/utils.py 93.54% <100.00%> (ø)
...c/sentry/integrations/slack/utils/notifications.py 77.90% <100.00%> (ø)
src/sentry/integrations/slack/webhooks/action.py 83.50% <100.00%> (ø)
src/sentry/integrations/utils/scope.py 95.65% <100.00%> (ø)
... and 4 more

@markstory markstory merged commit b77794c into master May 24, 2024
48 checks passed
@markstory markstory deleted the chore-integration-rpc-usage branch May 24, 2024 13:49
volokluev pushed a commit that referenced this pull request May 28, 2024
…1445)

Follow up to #71433 and part of the work to remove tuples from RPC
method signatures.

Refs HC-1190
markstory added a commit that referenced this pull request May 28, 2024
markstory added a commit that referenced this pull request May 30, 2024
Follow work done in #71445, #71376, to remove deprecated methods and
parameters. These changes also enable strict schema validation as all
tuples have been removed from parameters and return types and we want to
prevent new instances from creeping in.
Copy link

sentry-io bot commented Jun 5, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ RpcRemoteException: integration.organization_contexts: RPC failed, max retries reached. /extensions/github-enterprise/webhook/ View Issue
  • ‼️ RpcRemoteException: integration.organization_contexts: RPC failed, max retries reached. /extensions/github/webhook/ View Issue
  • ‼️ RpcRemoteException: integration.organization_contexts: RPC failed, max retries reached. /extensions/jira/issue-updated/ View Issue
  • ‼️ RpcRemoteException: integration.organization_contexts: RPC failed, max retries reached. /extensions/jira/issue-updated/ View Issue
  • ‼️ RpcRemoteException: integration.organization_contexts: RPC failed, max retries reached. /extensions/gitlab/webhook/ View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants