feat(query-builder): Add basic support for selecting multiple values #71457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
static/app/components/searchQueryBuilder/useQueryBuilderState.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #71457 +/- ##
===========================================
- Coverage 88.02% 77.88% -10.14%
===========================================
Files 2870 6537 +3667
Lines 178471 291097 +112626
Branches 32036 50391 +18355
===========================================
+ Hits 157093 226724 +69631
- Misses 15496 58125 +42629
- Partials 5882 6248 +366
|
malwilley
force-pushed
the
malwilley/feat/search-query-builder-multiple-values
branch
from
0766201
to
8b7bb09
Compare
| return {...state, query: replaceQueryToken(state.query, token.value, newValue)}; | ||
| } | ||
|
|
||
| function mutliSelectTokenValue( |
There was a problem hiding this comment.
Suggested change
| function mutliSelectTokenValue( | |
| function multiSelectTokenValue( |
last one I promise
(One usage of this function below too)
There was a problem hiding this comment.
How do I keep messing this up hah
| @@ -121,6 +198,10 @@ export function useQueryBuilderState({initialQuery}: {initialQuery: string}) { | |||
| return { | |||
| query: replaceQueryToken(state.query, action.token, action.value), | |||
| }; | |||
| case 'TOGGLE_FILTER_VALUE': | |||
| return mutliSelectTokenValue(state, action); | |||
There was a problem hiding this comment.
Suggested change
| return mutliSelectTokenValue(state, action); | |
| return multiSelectTokenValue(state, action); |
MichaelSun48
approved these changes
May 23, 2024
volokluev
pushed a commit
that referenced
this pull request
May 28, 2024
…71457) Ref #69791 For text and number filters, add checkboxes and allow multiple value selection. Other filter types retain the same functionality as before. Behavior is as follows: - Clicking the row selects the value and exits the token - Clicking the checkbox selects the value and keeps focus inside the token - Pressing backspace will unselect the previous value - Selected values are always shown at the top of the flyout
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #69791
For text and number filters, add checkboxes and allow multiple value selection. Other filter types retain the same functionality as before.
Behavior is as follows:
CleanShot.2024-05-23.at.11.30.05.mp4