-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(seer grouping): Add seer.similarity.supported_platforms
option
#72729
chore(seer grouping): Add seer.similarity.supported_platforms
option
#72729
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72729 +/- ##
===========================================
+ Coverage 51.46% 78.05% +26.59%
===========================================
Files 6574 6600 +26
Lines 293173 294329 +1156
Branches 50560 50756 +196
===========================================
+ Hits 150878 229740 +78862
+ Misses 140724 58349 -82375
- Partials 1571 6240 +4669
|
from sentry.constants import PLACEHOLDER_EVENT_TITLES | ||
from sentry.eventstore.models import Event | ||
from sentry.utils.safe import get_path | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
MAX_FRAME_COUNT = 50 | ||
SEER_ELIGIBLE_PLATFORMS = frozenset(["python", "javascript", "node"]) | ||
SEER_ELIGIBLE_PLATFORMS = options.get("seer.similarity.supported_platforms") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't work for a couple reasons:
- this attempts to access the database at import time when it is not available
- the value will not change as options are changed because it is only set at import time
going to revert because this is breaking mypy locally:
|
PR reverted: 2b3dc95 |
This changes our list of Seer similarity supported platforms to be configurable via the options automator. As we canonically support new platforms, we should still add them to the default value here (rather than adding them in the automator), but this will let us selectively enable or disable platforms on the fly as we're testing things out.