-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics-extraction): Selectable aggregates #73045
Merged
ArthurKnaus
merged 12 commits into
master
from
aknaus/feat/metrics-extraction/selectable-aggregates
Jul 2, 2024
Merged
feat(metrics-extraction): Selectable aggregates #73045
ArthurKnaus
merged 12 commits into
master
from
aknaus/feat/metrics-extraction/selectable-aggregates
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obostjancic
approved these changes
Jun 20, 2024
vgrozdanic
approved these changes
Jun 20, 2024
Bundle ReportChanges will increase total bundle size by 472 bytes ⬆️
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73045 +/- ##
==========================================
- Coverage 78.09% 78.04% -0.05%
==========================================
Files 6644 6638 -6
Lines 297094 296316 -778
Branches 51161 51059 -102
==========================================
- Hits 232015 231270 -745
+ Misses 58763 58745 -18
+ Partials 6316 6301 -15
|
matejminar
approved these changes
Jun 20, 2024
…-extraction/selectable-aggregates
priscilawebdev
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more for good luck 🍀
…-extraction/selectable-aggregates
Change the extraction conditions from strings to objects.
…-extraction/selectable-aggregates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Do Not Merge
Don't merge
Scope: Frontend
Automatically applied to PRs that change frontend components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove type selection in favor of selecting aggregates.