Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-extraction): Selectable aggregates #73045

Merged

Conversation

ArthurKnaus
Copy link
Member

@ArthurKnaus ArthurKnaus commented Jun 20, 2024

Remove type selection in favor of selecting aggregates.

Screenshot 2024-06-26 at 06 36 22

@ArthurKnaus ArthurKnaus requested a review from a team as a code owner June 20, 2024 09:08
@ArthurKnaus ArthurKnaus added the Do Not Merge Don't merge label Jun 20, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Bundle Report

Changes will increase total bundle size by 472 bytes ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 27.25MB 472 bytes ⬆️

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 78.04%. Comparing base (dda2a92) to head (3243e22).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #73045      +/-   ##
==========================================
- Coverage   78.09%   78.04%   -0.05%     
==========================================
  Files        6644     6638       -6     
  Lines      297094   296316     -778     
  Branches    51161    51059     -102     
==========================================
- Hits       232015   231270     -745     
+ Misses      58763    58745      -18     
+ Partials     6316     6301      -15     
Files Coverage Δ
...pp/views/settings/projectMetrics/extractMetric.tsx 0.00% <ø> (ø)
.../projectMetrics/metricsExtractionRuleEditModal.tsx 0.00% <ø> (ø)
...ngs/projectMetrics/metricsExtractionRulesTable.tsx 0.00% <0.00%> (ø)
...ic/app/views/settings/projectMetrics/utils/api.tsx 0.00% <0.00%> (ø)
...tings/projectMetrics/metricsExtractionRuleForm.tsx 0.00% <0.00%> (ø)

... and 437 files with indirect coverage changes

Copy link
Member

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more for good luck 🍀

@ArthurKnaus ArthurKnaus merged commit dfb02cb into master Jul 2, 2024
41 of 42 checks passed
@ArthurKnaus ArthurKnaus deleted the aknaus/feat/metrics-extraction/selectable-aggregates branch July 2, 2024 10:58
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Do Not Merge Don't merge Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants