Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(issues): Remove state from highlight event edit #73098

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

scttcper
Copy link
Member

  • removes the editAction state and shares the modal via a hook
  • removes unused Group prop

- removes the editAction state and shares the modal via a hook
- removes unused Group prop
@scttcper scttcper requested a review from a team as a code owner June 21, 2024 00:00
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.97%. Comparing base (bca0bde) to head (2e15202).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #73098   +/-   ##
=======================================
  Coverage   77.97%   77.97%           
=======================================
  Files        6619     6619           
  Lines      295416   295447   +31     
  Branches    50882    50885    +3     
=======================================
+ Hits       230352   230378   +26     
- Misses      58788    58793    +5     
  Partials     6276     6276           
Files Coverage Δ
...ils/groupEventDetails/groupEventDetailsContent.tsx 62.22% <ø> (ø)
...onents/events/highlights/highlightsDataSection.tsx 94.28% <88.23%> (+0.53%) ⬆️

... and 15 files with indirect coverage changes

@scttcper scttcper merged commit 087740d into master Jun 24, 2024
43 checks passed
@scttcper scttcper deleted the scttcper/ref-highlighted-events-state branch June 24, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants