Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query-builder): Add absolute date picker for date filters #73321

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

malwilley
Copy link
Member

@malwilley malwilley commented Jun 25, 2024

Sorry for the large diff, much of this is copying over an existing component from SmartSearchBar (the original will be deleted along with that component when it is no longer needed).

Requires #73324 to be merged first

CleanShot.2024-06-25.at.12.46.29.mp4

@malwilley malwilley requested a review from a team June 25, 2024 19:56
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 25, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was mostly copied from SearchBarDatePicker in SmartSearchBar, but needed enough changes that it should be its own component. The original will be deleted when SmartSearchBar is anyway.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 75.51020% with 36 lines in your changes missing coverage. Please review.

Project coverage is 78.01%. Comparing base (accca8f) to head (16dc512).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #73321    +/-   ##
========================================
  Coverage   78.01%   78.01%            
========================================
  Files        6632     6633     +1     
  Lines      296124   296253   +129     
  Branches    50999    51024    +25     
========================================
+ Hits       231031   231135   +104     
- Misses      58807    58833    +26     
+ Partials     6286     6285     -1     
Files Coverage Δ
...tatic/app/components/searchQueryBuilder/filter.tsx 96.34% <100.00%> (+0.09%) ⬆️
...p/components/searchQueryBuilder/filterOperator.tsx 94.44% <ø> (ø)
...archQueryBuilder/filterValueParser/date/parser.tsx 100.00% <100.00%> (ø)
...tic/app/components/searchQueryBuilder/combobox.tsx 81.75% <83.33%> (+1.60%) ⬆️
...pp/components/searchQueryBuilder/valueCombobox.tsx 82.91% <89.18%> (+1.45%) ⬆️
...onents/searchQueryBuilder/useQueryBuilderState.tsx 67.28% <28.57%> (-1.34%) ⬇️
...mponents/searchQueryBuilder/specificDatePicker.tsx 69.73% <69.73%> (ø)

... and 11 files with indirect coverage changes

Copy link

codecov bot commented Jun 25, 2024

Bundle Report

Changes will increase total bundle size by 6.36kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 27.29MB 6.36kB ⬆️

Co-authored-by: Scott Cooper <scttcper@gmail.com>
Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it hurts to approve popperjs

@malwilley malwilley merged commit ae41258 into master Jun 26, 2024
42 checks passed
@malwilley malwilley deleted the malwilley/feat/search-query-builder-abs-date branch June 26, 2024 16:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants