-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query-builder): Add absolute date picker for date filters #73321
feat(query-builder): Add absolute date picker for date filters #73321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was mostly copied from SearchBarDatePicker in SmartSearchBar, but needed enough changes that it should be its own component. The original will be deleted when SmartSearchBar is anyway.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73321 +/- ##
========================================
Coverage 78.01% 78.01%
========================================
Files 6632 6633 +1
Lines 296124 296253 +129
Branches 50999 51024 +25
========================================
+ Hits 231031 231135 +104
- Misses 58807 58833 +26
+ Partials 6286 6285 -1
|
…ch-query-builder-abs-date
Bundle ReportChanges will increase total bundle size by 6.36kB ⬆️
|
static/app/components/searchQueryBuilder/specificDatePicker.tsx
Outdated
Show resolved
Hide resolved
static/app/components/searchQueryBuilder/specificDatePicker.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Scott Cooper <scttcper@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it hurts to approve popperjs
Sorry for the large diff, much of this is copying over an existing component from SmartSearchBar (the original will be deleted along with that component when it is no longer needed).
Requires #73324 to be merged first
CleanShot.2024-06-25.at.12.46.29.mp4