Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
ref(settings): improve padding and layout consistency with spacing scale #7660
This pull fixes a bunch of padding inconsistencies by adding a basic scale system.
Currently, we use
This proposal would move us towards something that will always work across multiple-use cases: be it a styled component, an inline-style, a layout utility component like
This system will work for
Finally, it opens up a door towards typography and white-space scales that work together in harmony. This will make it easier to compose combinations of font-size, line-height, and margin + padding.
…ale (#7660) * first commit * second commit * 4 billy * use spacing functions that add unitless numbers * couple small fixes * use simple margin and padding shorhand functions when possible because they exactly mimic css * don't need index * just interpolate the spacing scale for now rather than mixing in full lines * decrease number of options in spacing scale * return of getPadding * bettar diff * re-add missing text transform line * fix import in panel header * reset these snapshots in some hairbrained scheme to convince github there are no conflicts * use fewer values for our scale and set it to a base of 8 * fix alignment issues by adding scale values for fieldWrapper * spacingScale => space * team members padding was too small