feat(ui): Use SelectControl in Context Picker Modal #8688
Conversation
| // Focus this to get hotkeys to keep working | ||
| let containerEl = document.querySelector('.main-container'); | ||
| if (containerEl) { | ||
| containerEl.focus(); |
There was a problem hiding this comment.
This seems hacky, but not sure of a better solution.
There was a problem hiding this comment.
Could it be done with ref like in
https://github.com/getsentry/sentry/blob/master/src/sentry/static/sentry/app/components/assigneeSelector.jsx#L292 ?
There was a problem hiding this comment.
The problem is when you close the modal, global hot keys stop working because the main body doesn't have focus. This is focusing an app container that's higher up in the tree. Ah after looking at it, .main-container is the parent so we may be able to just use a callback, for some reason I thought it was higher up in the tree.
Use new SelectControl in Context Picker Modal.
billyvg
force-pushed
the
fix/ui/use-select-context-modal-picker
branch
from
8deab44
to
135dfe5
Compare
| shouldHaveEmptyOrgSelector ? '' : latestContext.organization.slug | ||
| } | ||
| onChange={this.handleSelectOrganization} | ||
| <React.Fragment> |
| if (!this.projectSelect || this.state.loading) return; | ||
|
|
||
| // eslint-disable-next-line react/no-find-dom-node | ||
| ReactDOM.findDOMNode(this.projectSelect) |
There was a problem hiding this comment.
We should be able to use forwardRef to clean this up, but there's some issues with react-test-renderer serializing it.
* [ ] requires a PR in getsentry to be deployed together * [x] kill the old Account Notifications page before proceeding. Depends on: * ~~#8688 * ~~#8723 * ~~getsentry/getsentry#1961
* [ ] requires a PR in getsentry to be deployed together * [x] kill the old Account Notifications page before proceeding. Depends on: * ~~#8688 * ~~#8723 * ~~https://github.com/getsentry/getsentry/pull/1961~~
Use new SelectControl in Context Picker Modal.
Fix hot keys not working after closing modal.