Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(ui): svg-based bar charts #8802

Merged
merged 30 commits into from
Oct 1, 2018
Merged

ref(ui): svg-based bar charts #8802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
90ec931
random height
Chrissy Jun 7, 2018
3330874
rough working scalable version
Chrissy Sep 18, 2018
8ada768
perfect crop box
Chrissy Sep 18, 2018
e04e8d7
improve bar spacing to look identical to old spacing
Chrissy Sep 18, 2018
3edc908
working stax
Chrissy Sep 18, 2018
dae1ae7
only have a min height on the first bar
Chrissy Sep 18, 2018
4778688
remove createReactClass for posterity of the world
Chrissy Sep 18, 2018
c8cdbf5
use container: body so that tooltips can render outside the svg ns
Chrissy Sep 19, 2018
b3fdab6
cleanup and tests
Chrissy Sep 19, 2018
51bb905
patch more css hidden in weird nooks
Chrissy Sep 20, 2018
af04721
found a couple more bits of css
Chrissy Sep 20, 2018
b8ab38d
enable customization of things like min height and gap space since th…
Chrissy Sep 20, 2018
a9bbeaa
working markers
Chrissy Sep 21, 2018
1cb7422
use masking for fixed spaces between bars
Chrissy Sep 24, 2018
9d29796
add circles to svg and fix id bug with clip-path
Chrissy Sep 24, 2018
62c7d92
use proper gap in groupChart view
Chrissy Sep 24, 2018
2bca6db
perfect identicalness to current charts
Chrissy Sep 25, 2018
da4aeb5
fix min height for super short project stats graph
Chrissy Sep 25, 2018
a9135dd
show tooltip during any hover contact with bar height, empty or not
Chrissy Sep 25, 2018
703c508
fix min heights on group chart
Chrissy Sep 25, 2018
2ffb198
remove unecessary gap=2 stuff
Chrissy Sep 25, 2018
ddeb43e
add an extra 5% at the top of bar charts to prevent extra minheight c…
Chrissy Sep 25, 2018
ac7ec91
remove chart marker css
Chrissy Sep 25, 2018
60d673e
add params to 'bizarre case' code
Chrissy Sep 25, 2018
1219f8f
fix tooltip placement on smaller graphs
Chrissy Sep 26, 2018
cb8ece8
place circles as seperate svgs
Chrissy Sep 26, 2018
de6be6b
convert to percentage based gap widths because it is simple and with …
Chrissy Sep 26, 2018
4c0aa82
project stats gap
Chrissy Sep 26, 2018
593a722
add comments and use a stretch viewbox for safety reasons
Chrissy Oct 1, 2018
8bc282c
update comment to make more sense
Chrissy Oct 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/sentry/static/sentry/app/components/group/releaseChart.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import StackedBarChart from 'app/components/stackedBarChart';
import SentryTypes from 'app/sentryTypes';
import {t} from 'app/locale';
import {escape, intcomma} from 'app/utils';
import theme from 'app/utils/theme';

const GroupReleaseChart = createReactClass({
displayName: 'GroupReleaseChart',
Expand Down Expand Up @@ -118,6 +119,8 @@ const GroupReleaseChart = createReactClass({
label: t('First seen'),
x: firstSeenX,
className: 'first-seen',
offset: -7.5,
fill: theme.pink,
});
}
}
Expand All @@ -129,6 +132,7 @@ const GroupReleaseChart = createReactClass({
label: t('Last seen'),
x: lastSeenX,
className: 'last-seen',
fill: theme.green,
});
}
}
Expand All @@ -145,6 +149,8 @@ const GroupReleaseChart = createReactClass({
markers={markers}
barClasses={['release', 'environment', 'inactive']}
tooltip={this.renderTooltip}
gap={0.75}
minHeights={[0, 0, 5]}
/>
</div>
);
Expand Down
Loading