Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(symcache): Allow functions with more than 65k lines #155

Merged
merged 3 commits into from
Jul 2, 2019
Merged

fix(symcache): Allow functions with more than 65k lines #155

merged 3 commits into from
Jul 2, 2019

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Jul 1, 2019 •
edited
Loading

This fixes three conditions:

  1. It allows functions with more than 65k line records by splitting the address range and allowing multiple function records.
  2. It splits functions with a code length of more than 65k bytes (using the same mechanism)
  3. It no longer emits any function records without line records.
  4. bugfix: do not skip to write line records between sibling inlined functions

The bugfix is achieved by creating an isolated line cache for every layer when recursing into inlinees. Since line records might be missing from existing symcaches, the symcache version was bumped.

@jan-auer jan-auer requested a review from mitsuhiko July 1, 2019 13:35
@jan-auer jan-auer self-assigned this Jul 1, 2019
@jan-auer jan-auer force-pushed the feat/symcache-line-records branch from 670cf4b to 9356a8e Compare July 1, 2019 13:35
@jan-auer
Copy link
Member Author

jan-auer commented Jul 1, 2019

Verified with an offending debug symbol.

@jan-auer jan-auer merged commit e9407cf into master Jul 2, 2019
@jan-auer jan-auer deleted the feat/symcache-line-records branch July 2, 2019 09:31
jan-auer added a commit that referenced this pull request Jul 10, 2019
@jan-auer
Merge branch 'master' into ref/unreal4
24ef277 
* master:
  fix(minidump): Do not emit default CFI for the .ra register (#157)
  ref(example): Output debug ids in breakpad format in dump_cfi
  feat(example): Output a breakpad module header in dump_cfi
  build: Switch to crates releases
  fix(symcache): Allow functions with more than 65k lines (#155)
@jan-auer jan-auer mentioned this pull request Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsuhiko mitsuhiko mitsuhiko approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jan-auer @mitsuhiko