Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(minidump): Do not emit default CFI for the .ra register #157

Merged
merged 1 commit into from
Jul 5, 2019
Merged

fix(minidump): Do not emit default CFI for the .ra register #157

merged 1 commit into from
Jul 5, 2019

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Jul 5, 2019

Preliminary fix for recursions in stackwalking with CFI on Linux. This no longer emits a default rule for the .ra register. The rule was initially introduced to create parity with Breakpad, but turns out to be plain wrong.

There will be a more elaborate fix once gimli has been updated.

@jan-auer jan-auer requested a review from mitsuhiko July 5, 2019 19:01
@jan-auer jan-auer self-assigned this Jul 5, 2019
@jan-auer jan-auer merged commit 51f0516 into master Jul 5, 2019
@jan-auer jan-auer deleted the fix/cfi-ra branch July 5, 2019 19:29
jan-auer added a commit that referenced this pull request Jul 10, 2019
@jan-auer
Merge branch 'master' into ref/unreal4
24ef277 
* master:
  fix(minidump): Do not emit default CFI for the .ra register (#157)
  ref(example): Output debug ids in breakpad format in dump_cfi
  feat(example): Output a breakpad module header in dump_cfi
  build: Switch to crates releases
  fix(symcache): Allow functions with more than 65k lines (#155)
jan-auer added a commit that referenced this pull request Jul 10, 2019
@jan-auer
Merge branch 'master' into feat/sources
8882759 
* master:
  ref(unreal): Update unreal parsing (#152)
  fix(minidump): Do not emit default CFI for the .ra register (#157)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsuhiko mitsuhiko mitsuhiko approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jan-auer @mitsuhiko