fix(symcache): Compute correct line offsets #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second part of the fix will not work if we are running into I'm trying to check if we can instead store the size of the line record. |
Swatinem
approved these changes
Feb 3, 2021
Swatinem
approved these changes
Feb 4, 2021
jan-auer
added a commit
that referenced
this pull request
Feb 4, 2021
* master: fix(symcache): Compute correct line offsets (#319) release: 8.0.3 meta: Changelog
jan-auer
added a commit
that referenced
this pull request
Mar 1, 2021
* master: test: add similar-asserts' assert_eq (#333) release: 8.0.4 meta: Changelog for 8.0.4 build: Drop support for python 2.7 (#328) meta(vscode): Fix include paths for C++ (#331) doc(debuginfo): Add descriptions of records to breakpad.pest (#329) build: Replace virtualenv with venv doc(symcache): Symcache documentation fix(debuginfo): Support debug_addr indexes in DWARF functions (#326) fix(symcache): Fixed bug that caused functions to have len 0 (#324) ref(symcache): FuncRecord::len must be nonzero (#323) fix: Clippy 1.50 lints (#322) fix(symcache): Support lookup for public syms larger than 65k (#320) fix(symcache): Compute correct line offsets (#319) release: 8.0.3 meta: Changelog build: Update goblin to 0.3.1 (#318) fix(elf): Consider sections of type SHT_MIPS_DWARF (#317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SymCaches store line records where record specifies the delta to the previous line record. These deltas are stored as
u8to save space for the common case where only small increments are needed. If two records are more than0xffapart, we insert filler line records.This PR solves two bugs in creating these filler line records:
(diff & 0xff) as u8instead ofdiff.min(0xff) as u8. This means that there was an address drift every time we had to insert filler line records.SymCache version is incremented to
6.The previous implementation originates affe7b9 and 5209ebd and was subsequently amended with split functions in #155.