-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(unreal): Update unreal parsing #152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bruno-garcia
approved these changes
Jun 18, 2019
untitaker
approved these changes
Jun 19, 2019
This is final now. Going to merge once this has been implemented (and thus tried out) in Sentry. |
mitsuhiko
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Unreal API and modernizes it a little.
Most important changes
Minidump
.bytes::Buf
toscroll
.Other changes
Unreal4File
now owns a handle to its data. Since the offsets are already verified when parsing the entire crash, one doesn't need to hold on to the entire crash.flate2
, which is also used insymbolic_debuginfo
and insymbolicator
. One less dependency.Unreal4Crash.process_minidump
, one can get the minidump file and then process it usingProcessState.from_minidump_buffer
. This creates cleaner separation of concerns.scroll
).When updating
symbolic
prior to the 6.0 release, this was missed. Since this is a breaking change, we will likely have to bump symbolic to 7.0 after this.