Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename architecture to wasm32 #294

Merged
merged 1 commit into from
Nov 28, 2020
Merged

feat: Rename architecture to wasm32 #294

merged 1 commit into from
Nov 28, 2020

Conversation

mitsuhiko
Copy link
Member

Since there are two wasm architectures (32 and 64) we should be explicit about the architectures in code.

See https://github.com/WebAssembly/design/blob/master/CAndC%2B%2B.md

@mitsuhiko mitsuhiko requested a review from a team November 28, 2020 11:58
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT if we add Wasm64 to Arch and CPUFamily right away?

Edit: Or potentially Wasm makes more sense instead of CPUFamily, but considering that we declare the IP size on the CPU Family, I think it should be separate.

@mitsuhiko mitsuhiko merged commit 297bd3b into master Nov 28, 2020
@mitsuhiko mitsuhiko deleted the feature/wasm32 branch November 28, 2020 23:34
@mitsuhiko
Copy link
Member Author

I had Wasm as family in the beginning but we also split x86 and x86_64 apart so I'm not sure.

mitsuhiko added a commit that referenced this pull request Nov 28, 2020
jan-auer added a commit that referenced this pull request Dec 22, 2020
* master: (21 commits)
  fix: New nightly clippy lint (#295)
  fix(release): Do not publish examples to crates.io
  release: 8.0.0
  ref(debuginfo): Remove re-exports of error types (#300)
  meta: Update changelog
  ref(debuginfo): Switch to error with kind (#299)
  ref(minidump): Switch to error with kind (#298)
  ref(unreal): Switch to error with kind (#297)
  ref(symcache): Switch to error with kind (#296)
  feat: Rename architecture to wasm32 (#294)
  fix(debuginfo): Prefer DWARF names for Dart functions (#293)
  fix: clippy (#292)
  hack(dwarf): Skip line program sequences at 0 (#291)
  feat(wasm): support for wasm (#166)
  ci: Run rust nighlty on a schedule (#289)
  ref: Updates for rust 1.48 (#288)
  fix(debuginfo): Update dmsort to 1.0.1 to avoid panic due to UB (#287)
  ci: Use GHA instead of zeus (#286)
  ref: Introduce explicit NameMangling and better DemangleOptions (#275)
  meta: Bump all semver-major dependencies (#283)
  ...
jan-auer added a commit that referenced this pull request Dec 23, 2020
* master:
  fix: Update breakpad to version which fixes debug_id (#281)
  fix(pytest): Pin pytest 5 for debugfail customizations (#305)
  fix: New nightly clippy lint (#295)
  fix(release): Do not publish examples to crates.io
  release: 8.0.0
  ref(debuginfo): Remove re-exports of error types (#300)
  meta: Update changelog
  ref(debuginfo): Switch to error with kind (#299)
  ref(minidump): Switch to error with kind (#298)
  ref(unreal): Switch to error with kind (#297)
  ref(symcache): Switch to error with kind (#296)
  feat: Rename architecture to wasm32 (#294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants