ref(debuginfo): Switch to error with kind #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Nov 30, 2020
symbolic-debuginfo/src/object.rs
Outdated
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| match self.repr { | ||
| ObjectErrorRepr::Transparent(ref inner) => inner.fmt(f), | ||
| _ => self.repr.fmt(f), |
There was a problem hiding this comment.
Should we maybe call fmt::Debug::fmt directly? Otherwise, which fmt method does this resolve to? Same for the other .fmt calls.
There was a problem hiding this comment.
Good question. This always used to resolve correctly in the past, but it's probably worth disambiguating this.
Swatinem
reviewed
Nov 30, 2020
| InvertedFunctionRange, | ||
|
|
||
| /// The DWARF file is corrupted. See the cause for more information. | ||
| #[error("corrupted dwarf debug data")] | ||
| CorruptedData(#[from] GimliError), |
There was a problem hiding this comment.
GimliError was exposed because of the pub usage here. Maybe we can hide all the gimli re-exports again?
There was a problem hiding this comment.
Good catch, I'll create a follow-up.
jan-auer
added a commit
that referenced
this pull request
Dec 22, 2020
* master: (21 commits) fix: New nightly clippy lint (#295) fix(release): Do not publish examples to crates.io release: 8.0.0 ref(debuginfo): Remove re-exports of error types (#300) meta: Update changelog ref(debuginfo): Switch to error with kind (#299) ref(minidump): Switch to error with kind (#298) ref(unreal): Switch to error with kind (#297) ref(symcache): Switch to error with kind (#296) feat: Rename architecture to wasm32 (#294) fix(debuginfo): Prefer DWARF names for Dart functions (#293) fix: clippy (#292) hack(dwarf): Skip line program sequences at 0 (#291) feat(wasm): support for wasm (#166) ci: Run rust nighlty on a schedule (#289) ref: Updates for rust 1.48 (#288) fix(debuginfo): Update dmsort to 1.0.1 to avoid panic due to UB (#287) ci: Use GHA instead of zeus (#286) ref: Introduce explicit NameMangling and better DemangleOptions (#275) meta: Bump all semver-major dependencies (#283) ...
jan-auer
added a commit
that referenced
this pull request
Dec 23, 2020
* master: fix: Update breakpad to version which fixes debug_id (#281) fix(pytest): Pin pytest 5 for debugfail customizations (#305) fix: New nightly clippy lint (#295) fix(release): Do not publish examples to crates.io release: 8.0.0 ref(debuginfo): Remove re-exports of error types (#300) meta: Update changelog ref(debuginfo): Switch to error with kind (#299) ref(minidump): Switch to error with kind (#298) ref(unreal): Switch to error with kind (#297) ref(symcache): Switch to error with kind (#296) feat: Rename architecture to wasm32 (#294)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the conventions set by
std::io::Error.