Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pytest): Pin pytest 5 for debugfail customizations #305

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

jan-auer
Copy link
Member

With pytest 6, the internal representation of tests seems to have changed. Our overrides in conftest.py no longer emit compatible output which causes pytest to fail with an INTERNALERROR.

Until we get that fixed, this pins pytest to v5.

@jan-auer jan-auer requested review from flub and a team December 23, 2020 09:13
@jan-auer jan-auer self-assigned this Dec 23, 2020
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't even show up on pytest's changelog. Their API surface is so huge and uncharted...

@jan-auer jan-auer merged commit d33e4e0 into master Dec 23, 2020
@jan-auer jan-auer deleted the fix/pin-pytest-5 branch December 23, 2020 09:37
jan-auer added a commit that referenced this pull request Dec 23, 2020
* master:
  fix(pytest): Pin pytest 5 for debugfail customizations (#305)
jan-auer added a commit that referenced this pull request Dec 23, 2020
* master:
  fix: Update breakpad to version which fixes debug_id (#281)
  fix(pytest): Pin pytest 5 for debugfail customizations (#305)
  fix: New nightly clippy lint (#295)
  fix(release): Do not publish examples to crates.io
  release: 8.0.0
  ref(debuginfo): Remove re-exports of error types (#300)
  meta: Update changelog
  ref(debuginfo): Switch to error with kind (#299)
  ref(minidump): Switch to error with kind (#298)
  ref(unreal): Switch to error with kind (#297)
  ref(symcache): Switch to error with kind (#296)
  feat: Rename architecture to wasm32 (#294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants