ref(symcache): FuncRecord::len must be nonzero #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
requested changes
Feb 12, 2021
jan-auer
requested changes
Feb 15, 2021
symbolic-symcache/src/writer.rs
Outdated
| 0 => !0, | ||
| s => s, | ||
| 0 => u16::MAX, | ||
| s => s as u16, |
There was a problem hiding this comment.
Only noticing this now: This will not clamp to u16::MAX and rather wrap around. Can you add the cmp::min back?
There was a problem hiding this comment.
Yes, I made a mistake while testing this. I'll add it back.
symbolic-symcache/src/writer.rs
Outdated
|
|
||
| // This unwrap cannot fail; if len is zero we have already panicked | ||
| // or continued. | ||
| let len = NonZeroU16::new(len).unwrap(); |
There was a problem hiding this comment.
nit: This is functionally equivalent, but you can avoid the unwrap if you write like this:
let len = match NonZeroU16::new(len) {
Some(len) => len,
None => continue,
};
jan-auer
approved these changes
Feb 15, 2021
loewenheim
added a commit
to getsentry/symbolicator
that referenced
this pull request
Feb 15, 2021
This incorporates pull request getsentry/symbolic#323.
loewenheim
added a commit
to getsentry/symbolicator
that referenced
this pull request
Feb 15, 2021
This incorporates pull request getsentry/symbolic#323.
jan-auer
added a commit
that referenced
this pull request
Mar 1, 2021
* master: test: add similar-asserts' assert_eq (#333) release: 8.0.4 meta: Changelog for 8.0.4 build: Drop support for python 2.7 (#328) meta(vscode): Fix include paths for C++ (#331) doc(debuginfo): Add descriptions of records to breakpad.pest (#329) build: Replace virtualenv with venv doc(symcache): Symcache documentation fix(debuginfo): Support debug_addr indexes in DWARF functions (#326) fix(symcache): Fixed bug that caused functions to have len 0 (#324) ref(symcache): FuncRecord::len must be nonzero (#323) fix: Clippy 1.50 lints (#322) fix(symcache): Support lookup for public syms larger than 65k (#320) fix(symcache): Compute correct line offsets (#319) release: 8.0.3 meta: Changelog build: Update goblin to 0.3.1 (#318) fix(elf): Consider sections of type SHT_MIPS_DWARF (#317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jan-auer and I believe that there is no reason to consider functions of length 0 in
symcacheand all such functions occurring in a debug object should be discarded before building the cache. The type of thelenfield of theFuncRecordstruct is changed fromu16toNonZeroU16to enforce this invariant.