Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add similar-asserts' assert_eq #333

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Conversation

mitsuhiko
Copy link
Member

For dog fooding diffed assertions.

@mitsuhiko mitsuhiko requested a review from a team February 26, 2021 23:06
@jan-auer jan-auer changed the title test: add similar-asserts' assert_eq test: Add similar-asserts' assert_eq Feb 27, 2021
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of those cases where a #[macro_use] extern crate could be useful. For now, let's keep it as is.

@mitsuhiko mitsuhiko merged commit ff46a24 into master Feb 27, 2021
@mitsuhiko mitsuhiko deleted the feature/similar-asserts branch February 27, 2021 16:59
@mitsuhiko
Copy link
Member Author

In theory one could pull it in via a prelude.

jan-auer added a commit that referenced this pull request Mar 1, 2021
* master:
  test: add similar-asserts' assert_eq (#333)
  release: 8.0.4
  meta: Changelog for 8.0.4
  build: Drop support for python 2.7 (#328)
  meta(vscode): Fix include paths for C++ (#331)
  doc(debuginfo): Add descriptions of records to breakpad.pest (#329)
  build: Replace virtualenv with venv
  doc(symcache): Symcache documentation
  fix(debuginfo): Support debug_addr indexes in DWARF functions (#326)
  fix(symcache): Fixed bug that caused functions to have len 0 (#324)
  ref(symcache): FuncRecord::len must be nonzero (#323)
  fix: Clippy 1.50 lints (#322)
  fix(symcache): Support lookup for public syms larger than 65k (#320)
  fix(symcache): Compute correct line offsets (#319)
  release: 8.0.3
  meta: Changelog
  build: Update goblin to 0.3.1 (#318)
  fix(elf): Consider sections of type SHT_MIPS_DWARF (#317)
jan-auer added a commit that referenced this pull request Mar 3, 2021
* master:
  build: Update pdb to 0.7.0 (#334)
  release: 8.0.5
  meta: Changelog
  fix(debuginfo): Detect more hidden symbols in swift sources (#316)
  test: add similar-asserts' assert_eq (#333)
  release: 8.0.4
  meta: Changelog for 8.0.4
  build: Drop support for python 2.7 (#328)
  meta(vscode): Fix include paths for C++ (#331)
  doc(debuginfo): Add descriptions of records to breakpad.pest (#329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants