Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure SOPS to be class based #48

Closed
twolfson opened this issue Feb 4, 2016 · 2 comments
Closed

Restructure SOPS to be class based #48

twolfson opened this issue Feb 4, 2016 · 2 comments

Comments

@twolfson
Copy link
Contributor

twolfson commented Feb 4, 2016

The current implementation of SOPS is functionally based. This is good for programs that rely on transforming data. However, it's beginning to get unwieldy with all of the state passing it is doing (e.g. digest, iv, key, and in #47 unencrypted_suffix).

I suggest considering a refactor to swap out the core with something more class based so state is always located on self. I will create a gist to provide examples of what I mean.

@jvehent
Copy link
Contributor

jvehent commented Feb 4, 2016

This is actually a duplicate of #3, but no one had time to work on it. That said, I agree wholeheartedly, but I'll close as duplicate and move your comment to #3.

@twolfson
Copy link
Contributor Author

twolfson commented Feb 4, 2016

Ah, sorry. I totally didn't see #3 =(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants