Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tikz image generation #10

Closed
xfbs opened this issue Oct 5, 2018 · 3 comments
Closed

Tikz image generation #10

xfbs opened this issue Oct 5, 2018 · 3 comments
Assignees

Comments

@xfbs
Copy link
Contributor

xfbs commented Oct 5, 2018

I'm currently using webgen for a personal project and I've really come to like it. I do feel that I could do a bit to improve the tikz support tho. So here's some questions/ideas:

  • Why are you calling pdflatex with the -shell-escape flag? That would be a potential security issue.
  • Would it make sense to add support for xelatex/lualatex? They natively support system fonts with fontspec.
  • Would it make sense to use \documentclass[tikz]{standalone}, in datawebgen/passive_sources/templates/tikz.template, because like the you don't need pdfcrop and you get a lot of useful packages pre-loaded?
  • Would it make sense to support generating *.svg images using pdf2svg from the Tikz drawings?
@gettalong gettalong self-assigned this Oct 7, 2018
@gettalong
Copy link
Owner

Thanks for the issue and the pull requests - I just wanted to let you know that it will take some time for me to look at the things you propose but from a quick look-through they seem okay and valid.

@xfbs
Copy link
Contributor Author

xfbs commented Oct 7, 2018

Hey, that's okay. I'm just contributing back the things I've tweaked on my end :)

@gettalong
Copy link
Owner

As for -shell-escape: I really don't know anymore :( But since webgen is normally run only locally it shouldn't be that much of a security problem.

I have integrated all your pull requests - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants