Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Start Date doesn't remove task from Actionable view #1039

Open
SqAtx opened this issue Mar 1, 2024 · 2 comments · Fixed by #1059
Open

Changing Start Date doesn't remove task from Actionable view #1039

SqAtx opened this issue Mar 1, 2024 · 2 comments · Fixed by #1059
Assignees
Labels
bug regression Essential features that recently broke reproducible-in-git Issues that affect the current dev version

Comments

@SqAtx
Copy link
Contributor

SqAtx commented Mar 1, 2024

This is related to other problems that I've noticed/filed on the megabranch, but I couldn't find a duplicate here. Similar to diegogangl#21 in that the DB has the correct data, but the UI hasn't been updated.

This is on commit 2ecc997

Steps

  • Go to the Actionable tab
  • Select a task (single click)
  • Click "Start Tomorrow"

or:

  • Go to the Actionable tab
  • Open a task (double click)
  • Change the start date to a date in the future

Expected

The task disappears from the Actionable view.

This is the behaviour in GTG 0.6.

Actual

The task is still visible in the Actionable view. I can update the view and make the disappear by:

  • switching to (for example) Open and back to Actionable
  • marking an Actionable task as done
@nekohayo nekohayo added bug reproducible-in-git Issues that affect the current dev version regression Essential features that recently broke labels Mar 1, 2024
@SqAtx
Copy link
Contributor Author

SqAtx commented Mar 2, 2024

Interestingly, the Actionable tab is updated as expected when you mark a child task as done and it unblocks its parent. The child disappears from the view (because it's now done) and the parent appears (because it's now actionable).

Side note: the other way doesn't work, but I'll create another ticket for it when I can take the time to reproduce it properly. If you add a child to an Actionable task, the now parent is supposed to disappear and the new child to appear. I think in 0.7, the child doesn't appear unless I actually restart GTG. But I'll confirm that later in a different ticket.

Actually, I just had to do it again, and the other way indeed doesn't work, but it might be the same problem as I described in the ticket description. When I add a child to an Actionable task, the now parent is supposed to disappear and the new child to appear. But neither happens until I go to Open and back to Actionable.

@SqAtx
Copy link
Contributor Author

SqAtx commented Jul 29, 2024

This came back :( I'm now on f501dfb

From the Actionable view:

  • Clicking on the checkbox to mark a task as done doesn't make the task disappear:
    image
    Going to Open and back to Actionable makes is disappear.

  • Adding a child to a task doesn't make the parent disappear:
    image
    image
    Going to Open and back to Actionable again does the right thing:
    image

  • Clicking on a task and clicking Start Tomorrow doesn't make it disappear. Again, going to Open and back to Actionable works.

I ran a git bisect for the last problem. It indeed worked after 6ceec80. It found commit a89f715. And indeed, reverting that comit on master fixes that problem.

While bisecting, I also noticed #1130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug regression Essential features that recently broke reproducible-in-git Issues that affect the current dev version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants